VictorPlusC commented on a change in pull request #17127:
URL: https://github.com/apache/beam/pull/17127#discussion_r837998117
##########
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts
##########
@@ -41,30 +41,20 @@ export class SidePanel extends BoxPanel {
constructor(
manager: ServiceManager.IManager,
rendermime: IRenderMimeRegistry,
- pageType: string
+ sessionContext: SessionContext,
+ title: string,
+ widget: ClustersWidget | InteractiveInspectorWidget
Review comment:
That would be better and it would certainly reduce clutter as well.
Thanks!
##########
File path:
sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts
##########
@@ -130,7 +120,6 @@ export class SidePanel extends BoxPanel {
this.dispose();
}
- private _clusters: ClustersWidget;
- private _inspector: InteractiveInspectorWidget;
+ private _widget: ClustersWidget | InteractiveInspectorWidget;
Review comment:
Resolved now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
