damccorm opened a new pull request, #17267: URL: https://github.com/apache/beam/pull/17267
**Summary of Changes** This pr is the first step towards full watermark estimation support - it introduces the mechanism used for watermark estimation including: - Validation (graph/fn.go) - Code generation (genx/genx.go) - Execution (exec/sdf.go and exec/sdf_invokers.go) - Propogating result back to the runner (exec/datasource.go, harness.go) - A concrete implementation of a wall clock observing estimator (sdf/watermarkEstimator.go) This is built according to the design specified here - https://docs.google.com/document/d/1DqCYJ-J1YGNelCRIcN5v6BQsZxJB2l5uWBmN4ti--Ew/edit?usp=sharing **Next Steps** This work does not attempt any of the following (though it is built in such a way that those should be cleanly supported in subsequent PRs): - Watermark state - Manual estimators (passed into ProcessElement) - Timestamp observing estimators (call ObserveTimestamp on each emitted timestamp) **Manual Testing** On top of all the unit tests introduced, I hacked the existing textio sdf doFn and added the following function: ``` func (fn *readSdfFn) CreateWatermarkEstimator() sdf.WallTimeWatermarkEstimator { return sdf.WallTimeWatermarkEstimator{} } ``` and ran wordCount (with the textio sdf version) on dataflow so that I could observe the output watermark was getting correctly updated to the current wall clock time: <img width="464" alt="image" src="https://user-images.githubusercontent.com/42773683/161610141-f38ce9f0-a598-45bd-aa5b-869c465300a5.png";> ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/42773683/161610141-f38ce9f0-a598-45bd-aa5b-869c465300a5.png"](https://user-images.githubusercontent.com/42773683/161610141-f38ce9f0-a598-45bd-aa5b-869c465300a5.png"){kind=link}
