mosche commented on code in PR #17113:
URL: https://github.com/apache/beam/pull/17113#discussion_r845347581
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisPartitioner.java:
##########
@@ -47,6 +47,26 @@
return null;
}
+ /**
+ * An explicit partitioner that always returns a {@code Nonnull} explicit
hash key. The partition
+ * key is irrelevant in this case, though it cannot be {@code null}.
+ */
+ interface ExplicitPartitioner<T> extends KinesisPartitioner<T> {
+ @Override
+ default @Nonnull String getPartitionKey(T record) {
+ return "a"; // will be ignored, but can't be null
Review Comment:
This value is really totally irrelevant and has no meaning (as long as it
doesn't fail validation checks), imho extracting it into a constant just
overloads it with meaning it doesn't have...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
