diegomez17 commented on code in PR #16939:
URL: https://github.com/apache/beam/pull/16939#discussion_r853528963
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableService.java:
##########
@@ -103,3 +103,8 @@ interface Reader {
*/
List<SampleRowKeysResponse> getSampleRowKeys(BigtableSource source) throws
IOException;
}
+
+
+
+
+
Review Comment:
Done.
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -210,6 +234,246 @@ public Row getCurrentRow() throws NoSuchElementException {
}
}
+ @VisibleForTesting
+ static class BigtableMiniBatchReaderImpl implements Reader {
+ private BigtableSession session;
+ private final BigtableSource source;
+ private Row currentRow;
+ private Queue<FlatRow> buffer;
+ private RowSet rowSet;
+ private ServiceCallMetric serviceCallMetric;
+ private Future<List<FlatRow>> future;
+ private ByteString lastFetchedRow;
+ private boolean lastFillComplete;
+
+ private int miniBatchLimit = DEFAULT_MINI_BATCH_SIZE;
+ private long bufferSizeLimit = DEFAULT_BYTE_LIMIT;
+ private int miniBatchWaterMark;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
