yeandy commented on code in PR #17196:
URL: https://github.com/apache/beam/pull/17196#discussion_r855515102


##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -85,6 +85,15 @@ toxTask "testPy38pandas-14", "py38-pandas-14"
 test.dependsOn "testPy38pandas-14"
 preCommitPy38.dependsOn "testPy38pandas-14"
 
+// Create a test task for each minor version of pytorch
+toxTask "testPy38pytorch-19", "py38-pytorch-19"
+test.dependsOn "testPy38pytorch-19"
+preCommitPy38.dependsOn "testPy38pytorch-19"
+
+toxTask "testPy38pytorch-110", "py38-pytorch-110"
+test.dependsOn "testPy38pytorch-110"
+preCommitPy38.dependsOn "testPy38pytorch-110"

Review Comment:
   Pytorch has a 90-day release cycle, but it doesn't seem that their changes 
really touch on the APIs that we use. 
   
   Maybe we can test the most recent release (pytorch 1.11.0), along with the 
last minor version of the last X major versions (pytorch 1.10.2, pytorch 1.9.1, 
pytorch 1.8.2, ...). I'll create a ticket to investigate this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to