damccorm commented on code in PR #17543:
URL: https://github.com/apache/beam/pull/17543#discussion_r865084625
##########
sdks/go/pkg/beam/core/runtime/exec/pardo.go:
##########
@@ -180,6 +180,10 @@ func (n *ParDo) processSingleWindow(mainIn *MainInput)
(sdf.ProcessContinuation,
// Forward direct output, if any. It is always a main output.
if val != nil {
+ // We do not forward a ProcessContinuation on its own
+ if val.Elm == nil && val.Continuation != nil {
Review Comment:
```suggestion
if val.Elm == nil {
```
Probably not a huge deal since we should never(?) get into a situation where
val != nil && val.Elm == nil && val.Continuation == nil, but this simplifies
things and helps us avoid potential for the same kind of issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
