TheNeuralBit commented on code in PR #17544:
URL: https://github.com/apache/beam/pull/17544#discussion_r870811522


##########
sdks/python/apache_beam/io/gcp/bigquery_test.py:
##########
@@ -833,6 +838,264 @@ def noop(table, **kwargs):
               test_client=client))
 
 
+class BigQueryStreamingInsertsErrorHandling(unittest.TestCase):

Review Comment:
   I think this suite should be skipped if bigquery fails to import, like the 
other suites in this file. Unfortunately I think that even with that, this test 
will break without GCP dependencies, since the test is parameterized by objects 
in `google.api.core.exceptions`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to