damccorm commented on PR #17650: URL: https://github.com/apache/beam/pull/17650#issuecomment-1125470664
> We do need it for the same reason. Please add a benchmark for wrapping and invoking a simple function caller, and you'll see. Oh yeah, my point isn't that it isn't much better in terms of performance, just that its not a huge usability win vs the user manually calling these themselves. The performance bump is evident from the existing benchmarks on `register.DoFnXxY` which are doing the same thing, I'm pretty happy to add the extra benchmark though, and will have it shortly. I should've been more clear in my original comment that I **do** still think this is a good idea, I just think it is less useful because its not too hard for users to do the right thing themselves already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
