andygrove opened a new issue, #330: URL: https://github.com/apache/datafusion-comet/issues/330
### What is the problem the feature request solves? https://github.com/apache/datafusion-comet/pull/307 fixes a correctness issue with casting from string to integer, but there is a question about performance in https://github.com/apache/datafusion-comet/pull/307#discussion_r1580451770. This issue is for benchmarking the native CAST operation versus Spark as well as looking at optimizing the code. Another area that could be optimized would be to avoid converting a string to a `Vec<char>` in `do_cast_string_to_int`: ```rust let chars: Vec<char> = str.chars().collect(); ``` We should be able to just use iterators over the underlying chars but we have to iterate from both start and end of the string, so it isn't trivial. ### Describe the potential solution _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
