alamb commented on code in PR #10319: URL: https://github.com/apache/datafusion/pull/10319#discussion_r1585465057
########## datafusion/optimizer/src/eliminate_nested_union.rs: ########## @@ -37,49 +38,61 @@ impl EliminateNestedUnion { impl OptimizerRule for EliminateNestedUnion { fn try_optimize( &self, - plan: &LogicalPlan, + _plan: &LogicalPlan, _config: &dyn OptimizerConfig, ) -> Result<Option<LogicalPlan>> { + internal_err!("Should have called EliminateFilter::rewrite") Review Comment: ```suggestion internal_err!("Should have called EliminateNestedUnion::rewrite") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org