andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1586652474
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -528,14 +528,29 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
"spark.comet.cast.stringToTimestamp is disabled")
}
- ignore("cast StringType to TimestampType") {
- // https://github.com/apache/datafusion-comet/issues/328
- withSQLConf((CometConf.COMET_CAST_STRING_TO_TIMESTAMP.key, "true")) {
- val values = Seq("2020-01-01T12:34:56.123456", "T2") ++
generateStrings(timestampPattern, 8)
- castTest(values.toDF("a"), DataTypes.TimestampType)
+ test("cast StringType to TimestampType") {
+ withSQLConf(
+ SQLConf.SESSION_LOCAL_TIMEZONE.key -> "UTC",
+ CometConf.COMET_CAST_STRING_TO_TIMESTAMP.key -> "true") {
+ val values = Seq(
+ "2020",
+ "2020-01",
+ "2020-01-01",
+ "2020-01-01T12",
+ "2020-01-01T12:34",
+ "2020-01-01T12:34:56",
+ "2020-01-01T12:34:56.123456",
+ "T2",
+ "-9?")
+ castTimestampTest(values.toDF("a"), DataTypes.TimestampType)
}
}
+ test("cast StringType to TimestampType with invalid timezone") {
Review Comment:
Thanks for adding this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
