alamb commented on code in PR #10370:
URL: https://github.com/apache/datafusion/pull/10370#discussion_r1589965987
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -49,6 +81,15 @@ pub fn expr_to_sql(expr: &Expr) -> Result<ast::Expr> {
unparser.expr_to_sql(expr)
}
+/// Convert a DataFusion [`Expr`] to [`Unparsed`]
+///
+/// This function is similar to expr_to_sql, but it supports converting more
[`Expr`] types like
Review Comment:
👍
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -197,13 +243,14 @@ impl Unparser<'_> {
.iter()
.map(|e| self.expr_to_sql(e))
.collect::<Result<Vec<_>>>()?,
- order_by: vec![],
+ order_by,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
