alamb commented on issue #10413:
URL: https://github.com/apache/datafusion/issues/10413#issuecomment-2099080156

   As @peter-toth  mentions in 
https://github.com/apache/datafusion/pull/10396#issuecomment-2099072200 this 
appears to be related to name resolution (not CSE). I checked with `EXPLAIN 
VERBOSE` and indeed the initial plan appears to be incorret
   
   ```sql
   DataFusion CLI v37.1.0
   > explain verbose select a + b from (select 1 as a, 2 as b, 1 as "a + b");
   
+------------------------------------------------------------+--------------------------------------------------------------------------------------------+
   | plan_type                                                  | plan          
                                                                             |
   
+------------------------------------------------------------+--------------------------------------------------------------------------------------------+
   | initial_logical_plan                                       | Projection: a 
+ b                                                                          |
   |                                                            |   Projection: 
Int64(1) AS a, Int64(2) AS b, Int64(1) AS a + b                              |
   |                                                            |     
EmptyRelation                                                                   
       |
   | logical_plan after apply_function_rewrites                 | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after inline_table_scan                       | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after type_coercion                           | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after count_wildcard_rule                     | SAME TEXT AS 
ABOVE                                                                         |
   | analyzed_logical_plan                                      | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_nested_union                  | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after simplify_expressions                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after unwrap_cast_in_comparison               | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after replace_distinct_aggregate              | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_join                          | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after decorrelate_predicate_subquery          | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after scalar_subquery_to_join                 | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after extract_equijoin_predicate              | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after simplify_expressions                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after rewrite_disjunctive_predicate           | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_duplicated_expr               | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_filter                        | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_cross_join                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after common_sub_expression_eliminate         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_limit                         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after propagate_empty_relation                | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_one_union                     | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after filter_null_join_keys                   | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_outer_join                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after push_down_limit                         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after push_down_filter                        | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after single_distinct_aggregation_to_group_by | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after simplify_expressions                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after unwrap_cast_in_comparison               | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after common_sub_expression_eliminate         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after optimize_projections                    | Projection: 
Int64(1) AS a + b                                                              |
   |                                                            |   
EmptyRelation                                                                   
         |
   | logical_plan after eliminate_nested_union                  | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after simplify_expressions                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after unwrap_cast_in_comparison               | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after replace_distinct_aggregate              | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_join                          | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after decorrelate_predicate_subquery          | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after scalar_subquery_to_join                 | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after extract_equijoin_predicate              | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after simplify_expressions                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after rewrite_disjunctive_predicate           | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_duplicated_expr               | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_filter                        | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_cross_join                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after common_sub_expression_eliminate         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_limit                         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after propagate_empty_relation                | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_one_union                     | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after filter_null_join_keys                   | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after eliminate_outer_join                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after push_down_limit                         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after push_down_filter                        | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after single_distinct_aggregation_to_group_by | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after simplify_expressions                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after unwrap_cast_in_comparison               | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after common_sub_expression_eliminate         | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan after optimize_projections                    | SAME TEXT AS 
ABOVE                                                                         |
   | logical_plan                                               | Projection: 
Int64(1) AS a + b                                                              |
   |                                                            |   
EmptyRelation                                                                   
         |
   | initial_physical_plan                                      | 
ProjectionExec: expr=[1 as a + b]                                               
           |
   |                                                            |   
PlaceholderRowExec                                                              
         |
   |                                                            |               
                                                                             |
   | initial_physical_plan_with_stats                           | 
ProjectionExec: expr=[1 as a + b], statistics=[Rows=Exact(1), Bytes=Exact(8), 
[(Col[0]:)]] |
   |                                                            |   
PlaceholderRowExec, statistics=[Rows=Exact(1), Bytes=Exact(0), []]              
         |
   |                                                            |               
                                                                             |
   | physical_plan after OutputRequirements                     | 
OutputRequirementExec                                                           
           |
   |                                                            |   
ProjectionExec: expr=[1 as a + b]                                               
         |
   |                                                            |     
PlaceholderRowExec                                                              
       |
   |                                                            |               
                                                                             |
   | physical_plan after aggregate_statistics                   | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after join_selection                         | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after LimitedDistinctAggregation             | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after EnforceDistribution                    | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after CombinePartialFinalAggregate           | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after EnforceSorting                         | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after OptimizeAggregateOrder                 | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after ProjectionPushdown                     | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after coalesce_batches                       | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after OutputRequirements                     | 
ProjectionExec: expr=[1 as a + b]                                               
           |
   |                                                            |   
PlaceholderRowExec                                                              
         |
   |                                                            |               
                                                                             |
   | physical_plan after PipelineChecker                        | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after LimitAggregation                       | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan after ProjectionPushdown                     | SAME TEXT AS 
ABOVE                                                                         |
   | physical_plan                                              | 
ProjectionExec: expr=[1 as a + b]                                               
           |
   |                                                            |   
PlaceholderRowExec                                                              
         |
   |                                                            |               
                                                                             |
   | physical_plan_with_stats                                   | 
ProjectionExec: expr=[1 as a + b], statistics=[Rows=Exact(1), Bytes=Exact(8), 
[(Col[0]:)]] |
   |                                                            |   
PlaceholderRowExec, statistics=[Rows=Exact(1), Bytes=Exact(0), []]              
         |
   |                                                            |               
                                                                             |
   
+------------------------------------------------------------+--------------------------------------------------------------------------------------------+
   77 row(s) fetched.
   Elapsed 0.032 seconds.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to