devanbenz commented on issue #9726:
URL: https://github.com/apache/datafusion/issues/9726#issuecomment-2099152834

   > It seems to me that `Expr::ScalarVariable` currently is parsed from 
`ast::Identifier` (that starts with `@`)-- perhaps instead of adding a new ast 
node, you could just create an equivalent `ast::Identifier` 🤔
   > 
   > 
https://github.com/apache/datafusion/blob/accce9732e26723cab2ffc521edbf5a3fe7460b3/datafusion/sql/src/expr/identifier.rs#L28-L43
   
   Sounds good - I'll have some time to come back to this in the next couple 
days! Will modify per your suggestion :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to