westonpace commented on issue #10374: URL: https://github.com/apache/datafusion/issues/10374#issuecomment-2101207112
I think it would actually be easier. The easiest was the old way where we have only `Expr::GetIndexedField` and `get_field` doesn't exist (no functions). However, that ship has already sailed (the functions are valuable because they allow extensibility). Today, I have to account for both paths. We use the SQL parser as our input. I don't know (off the top of my head) if it uses `Expr` or `get_field` and it doesn't really matter because, if I don't account for both, it will inevitably change which one it uses (murphy's law). So having one path, even if it is a slightly less obvious path, is better than having two paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
