comphead commented on code in PR #10356:
URL: https://github.com/apache/datafusion/pull/10356#discussion_r1597526491
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -66,26 +67,28 @@ impl AnalyzerRule for TypeCoercion {
}
fn analyze(&self, plan: LogicalPlan, _: &ConfigOptions) ->
Result<LogicalPlan> {
- analyze_internal(&DFSchema::empty(), &plan)
+ let empty_schema = DFSchema::empty();
+
+ let transformed_plan = plan
+ .transform_up_with_subqueries(|plan|
analyze_internal(&empty_schema, plan))?
+ .data;
+
+ Ok(transformed_plan)
}
}
+/// use the external schema to handle the correlated subqueries case
+///
+/// Assumes that children have already been optimized
fn analyze_internal(
- // use the external schema to handle the correlated subqueries case
external_schema: &DFSchema,
- plan: &LogicalPlan,
-) -> Result<LogicalPlan> {
- // optimize child plans first
- let new_inputs = plan
- .inputs()
- .iter()
- .map(|p| analyze_internal(external_schema, p))
- .collect::<Result<Vec<_>>>()?;
+ plan: LogicalPlan,
+) -> Result<Transformed<LogicalPlan>> {
// get schema representing all available input fields. This is used for
data type
// resolution only, so order does not matter here
- let mut schema = merge_schema(new_inputs.iter().collect());
+ let mut schema = merge_schema(plan.inputs());
Review Comment:
👍 q
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
