suremarc commented on PR #10434: URL: https://github.com/apache/datafusion/pull/10434#issuecomment-2109163914
Sorry @alamb @mustafasrepo, I completely missed this. My GH notifications tend to get drowned out by stuff from work, but I've discovered my personal email doesn't have this issue. I will check it every day from now on. As for this PR, looks great and I'm glad we don't have to declare equivalences backwards (`f(a) = b`) for the sort optimizations to work. I do think the `collapse_monotonic_lex_req` was a bit of a smell, so it's nice to move that logic closer into the `EquivalenceProperties` code 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
