alamb commented on code in PR #10510:
URL: https://github.com/apache/datafusion/pull/10510#discussion_r1602121592
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
+ Unknown,
}
Review Comment:
> What I saw is that sometimes ColumnStatistics { ..., min, max, ... } both
are equal to Precision::Absent. In such cases, we can't determine the type for
Interval.
Anywhere we have `ColumnStatistics` we should also have the schema (and
thus the `DataType` of all columns) -- maybe we just have to pass the schema
along with the statistics?
##########
datafusion/expr/src/interval_arithmetic.rs:
##########
@@ -1469,6 +1472,8 @@ pub enum NullableInterval {
MaybeNull { values: Interval },
/// The value is definitely not null, and is within the specified range.
NotNull { values: Interval },
+ /// Added to handle cases with insufficient statistics
Review Comment:
```suggestion
/// No information is known about this intervals values or nullness
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
