kazuyukitanimura commented on code in PR #441:
URL: https://github.com/apache/datafusion-comet/pull/441#discussion_r1605682420
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -576,11 +576,13 @@ class CometSparkSessionExtensions
// exchange. It is only used for Comet native execution. We only
transform Spark broadcast
// exchange to Comet broadcast exchange if its downstream is a Comet
native plan or if the
// broadcast exchange is forced to be enabled by Comet config.
+ // Note that `CometBroadcastExchangeExec` is only supported for Spark
3.4+.
case plan if
plan.children.exists(_.isInstanceOf[BroadcastExchangeExec]) =>
val newChildren = plan.children.map {
case b: BroadcastExchangeExec
if isCometNative(b.child) &&
- isCometOperatorEnabled(conf, "broadcastExchangeExec") =>
+ isCometOperatorEnabled(conf, "broadcastExchangeExec") &&
+ isSpark34Plus => // Spark 3.4+ only
Review Comment:
If `BroadcastExchangeExec` is only for 3.4+, is `isSpark34Plus` extra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
