alamb commented on code in PR #10568: URL: https://github.com/apache/datafusion/pull/10568#discussion_r1606978717
########## datafusion/functions/src/core/expr_ext.rs: ########## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Extension methods for Expr. + +use datafusion_expr::{Expr, Literal}; + +use super::expr_fn::get_field; + +pub trait FieldAccessor { + fn field(self, name: impl Literal) -> Expr; +} + +impl FieldAccessor for Expr { + /// Return access to the named field. Example `expr["name"]` Review Comment: likewise here I think we need to move the docs / example to `FieldAccessor` rather than on the impl in `Expr` ########## datafusion/physical-expr/src/planner.rs: ########## @@ -287,24 +284,6 @@ pub fn create_physical_expr( input_dfschema, execution_props, )?), - Expr::GetIndexedField(GetIndexedField { expr: _, field }) => match field { Review Comment: ❤️ ########## datafusion/functions-array/src/expr_ext.rs: ########## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Extension methods for Expr. + +use datafusion_expr::Expr; + +use crate::extract::{array_element, array_slice}; + +pub trait IndexAccessor { + fn index(self, key: Expr) -> Expr; +} + +impl IndexAccessor for Expr { + /// Return access to the element field. Example `expr["name"]` Review Comment: I think the way that rustdoc works, this documentation won't appear on `index` -- can you please move the docs and example to `IndexAccessor` itself? ########## datafusion/functions-array/src/expr_ext.rs: ########## @@ -0,0 +1,102 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Extension methods for Expr. Review Comment: This is a very clever idea. Thank you @jayzhan211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
