alamb commented on code in PR #10574: URL: https://github.com/apache/datafusion/pull/10574#discussion_r1608876810
########## datafusion/physical-expr-common/src/aggregate/groups_accumulator/mod.rs: ########## @@ -0,0 +1,20 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +pub mod accumulate; Review Comment: Perhaps we could add a note that this module is for implementing `GroupsAccumulator` ```suggestion //! Utilities for implementing [`GroupsAccumulator`] pub mod accumulate; ``` ########## Cargo.toml: ########## @@ -59,6 +59,9 @@ version = "38.0.0" # for the inherited dependency but cannot do the reverse (override from true to false). # # See for more detaiils: https://github.com/rust-lang/cargo/issues/11329 +ahash = { version = "0.8", default-features = false, features = [ Review Comment: 👍 ########## datafusion/physical-expr/src/aggregate/groups_accumulator/mod.rs: ########## @@ -15,10 +15,18 @@ // specific language governing permissions and limitations // under the License. -pub(crate) mod accumulate; mod adapter; -pub use accumulate::NullState; + Review Comment: 👍 for backwards compatibility Maybe we can leave a comment explaining it is for backwards compatibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
