goldmedal commented on PR #10573: URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2123883816
> Thank you @goldmedal -- I think this looks really nice > > Thank you for the reviews @comphead > > I left some suggestions for improvement but I think they could be done as follow on PRs as well. > > cc @phillipleblanc and @devinjdangelo and @backkem Thanks @alamb ! I think the suggestions is very simple and reasonable. So, I just fixed them in this PR quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
