westonpace commented on code in PR #10634:
URL: https://github.com/apache/datafusion/pull/10634#discussion_r1613461895
##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########
@@ -4374,6 +4374,42 @@ GROUP BY dummy
----
text1, text1, text1
+# Tests for aggregating with NaN values
+statement ok
+CREATE TABLE float_table (
+ col_f32 FLOAT,
+ col_f32_nan FLOAT,
+ col_f64 DOUBLE,
+ col_f64_nan DOUBLE
+) as VALUES
+( -128.2, -128.2, -128.2, -128.2 ),
+( 32768.3, arrow_cast('NAN','Float32'), 32768.3, 32768.3 ),
+( 27.3, arrow_cast('NAN','Float64'), 27.3, 27.3 );
Review Comment:
I'm not familiar with this particular corner of SQL but should this be...
```
( -128.2, -128.2, -128.2, -128.2 ),
( 32768.3, arrow_cast('NAN','Float32'), 32768.3, arrow_cast('NAN',
'Float64') ),
( 27.3, 27.3, 27.3, 27.3 );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
