tisonkun commented on PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#issuecomment-2136204241
I'm testing on @jmhain's branch on the subscript fixes and encounter the
following new API breaks:
```
Compiling datafusion-sql v38.0.0
(/Users/tison/Brittani/arrow-datafusion/datafusion/sql)
error[E0599]: no variant named `ArrayIndex` found for enum
`sqlparser::ast::Expr`
--> datafusion/sql/src/expr/mod.rs:197:22
|
197 | SQLExpr::ArrayIndex { obj, indexes } => {
| ^^^^^^^^^^ variant not found in
`sqlparser::ast::Expr`
error[E0599]: no variant or associated item named `RawStringLiteral` found
for enum `sqlparser::ast::Value` in the current scope
--> datafusion/sql/src/statement.rs:78:18
|
78 | | Value::RawStringLiteral(_)
| ^^^^^^^^^^^^^^^^
| |
| variant or associated item not found in `Value`
| help: there is a variant with a similar name:
`HexStringLiteral`
error[E0026]: variant `sqlparser::ast::Statement::SetVariable` does not have
a field named `variable`
--> datafusion/sql/src/statement.rs:232:17
|
232 | variable,
| ^^^^^^^^
| |
| variant `sqlparser::ast::Statement::SetVariable` does
not have this field
| help: a field with a similar name exists: `variables`
Compiling datafusion-functions-aggregate v38.0.0
(/Users/tison/Brittani/arrow-datafusion/datafusion/functions-aggregate)
error[E0004]: non-exhaustive patterns: `FunctionArgumentClause::Having(_)`
and `FunctionArgumentClause::Separator(_)` not covered
--> datafusion/sql/src/expr/function.rs:142:19
|
142 | match clause {
| ^^^^^^ patterns `FunctionArgumentClause::Having(_)`
and `FunctionArgumentClause::Separator(_)` not covered
|
note: `FunctionArgumentClause` defined here
-->
/Users/tison/.cargo/git/checkouts/sqlparser-rs-7df4902af8c87ae3/bd573b2/src/ast/mod.rs:4995:1
|
4995 | pub enum FunctionArgumentClause {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
5023 | Having(HavingBound),
| ------ not covered
...
5027 | Separator(Value),
| --------- not covered
= note: the matched value is of type `FunctionArgumentClause`
help: ensure that all possible cases are being handled by adding a match arm
with a wildcard pattern, a match arm with multiple or-patterns as shown, or
multiple match arms
|
166 ~ },
167 + FunctionArgumentClause::Having(_) |
FunctionArgumentClause::Separator(_) => todo!()
|
```
Also related to -
* https://github.com/sqlparser-rs/sqlparser-rs/pull/1262
* https://github.com/sqlparser-rs/sqlparser-rs/pull/1252
* https://github.com/sqlparser-rs/sqlparser-rs/pull/1258
* https://github.com/sqlparser-rs/sqlparser-rs/pull/1256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
