vaibhawvipul commented on code in PR #471: URL: https://github.com/apache/datafusion-comet/pull/471#discussion_r1619176000
########## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ########## @@ -1469,5 +1469,36 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper { } } } + test("unary negative integer overflow test") { + withTempDir { dir => + val path = new Path(dir.toURI.toString, "int.parquet") + val df = Seq(Int.MaxValue, Int.MinValue).toDF("a") + df.write.mode("overwrite").parquet(path.toString) + spark.read.parquet(path.toString).createTempView("t") + + // without ANSI mode + withSQLConf( Review Comment: @kazuyukitanimura I have added a Scalar test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org