alamb commented on PR #10556:
URL: https://github.com/apache/datafusion/pull/10556#issuecomment-2148401687

   There is some real problem with this PR
   
   ```
   (venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ cargo test 
--test sqllogictests -- expr
       Finished `test` profile [unoptimized + debuginfo] target(s) in 0.13s
        Running bin/sqllogictests.rs 
(target/debug/deps/sqllogictests-8ccf13b56f24ea6f)
   Running "expr.slt"
   thread 'tokio-runtime-worker' panicked at 
datafusion/common/src/scalar/mod.rs:1038:9:
   assertion failed: datatype.is_primitive()
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   External error: task 17 panicked
   Error: Execution("1 failures")
   error: test failed, to rerun pass `-p datafusion-sqllogictest --test 
sqllogictests`
   
   Caused by:
     process didn't exit successfully: 
`/Users/andrewlamb/Software/datafusion2/target/debug/deps/sqllogictests-8ccf13b56f24ea6f
 expr` (exit status: 1)
   ```
   
   And
   
   ```
   (venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ cargo test 
--test sqllogictests -- scalar
       Finished `test` profile [unoptimized + debuginfo] target(s) in 0.13s
        Running bin/sqllogictests.rs 
(target/debug/deps/sqllogictests-8ccf13b56f24ea6f)
   Running "scalar.slt"
   thread 'tokio-runtime-worker' panicked at 
datafusion/functions/src/math/log.rs:85:42:
   index out of bounds: the len is 1 but the index is 1
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   External error: task 17 panicked
   Error: Execution("1 failures")
   error: test failed, to rerun pass `-p datafusion-sqllogictest --test 
sqllogictests`
   
   Caused by:
     process didn't exit successfully: 
`/Users/andrewlamb/Software/datafusion2/target/debug/deps/sqllogictests-8ccf13b56f24ea6f
 scalar` (exit status: 1)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to