alamb commented on code in PR #10627:
URL: https://github.com/apache/datafusion/pull/10627#discussion_r1631304835
##########
datafusion/physical-expr/src/aggregate/min_max.rs:
##########
@@ -1103,3 +1117,41 @@ impl Accumulator for SlidingMinAccumulator {
std::mem::size_of_val(self) - std::mem::size_of_val(&self.min) +
self.min.size()
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ #[test]
+ fn float_min_max_with_nans() {
+ let pos_nan = f32::NAN;
+ let zero = 0_f32;
+ let neg_inf = f32::NEG_INFINITY;
+
+ let check = |acc: &mut dyn Accumulator, values: &[&[f32]], expected:
f32| {
Review Comment:
😍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
