eejbyfeldt commented on code in PR #620:
URL: https://github.com/apache/datafusion-comet/pull/620#discussion_r1663163933


##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2626,6 +2645,11 @@ object QueryPlanSerde extends Logging with 
ShimQueryPlanSerde with CometExprShim
           return None
         }
 
+        if ((join.leftKeys ++ 
join.rightKeys).exists(_.dataType.isInstanceOf[StructType])) {
+          withInfo(join, "Unsupported struct data type in join keys")
+          return None
+        }

Review Comment:
   Seems like we this should be resolved in future versions of datafusion. With 
https://github.com/apache/datafusion/pull/11232 taking care of the last issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to