jayzhan211 commented on issue #11212: URL: https://github.com/apache/datafusion/issues/11212#issuecomment-2205272844
> What I'm trying to get at is that there's currently unnecessary computation happening within `BinaryExpr` (perhaps in many cases, just calculating the `left` side would be sufficient to determine the result). I would be surprise if there is any, could you provide the example that shows optimizer failed to do what you expect? Here is the optimize rule that skip the right hand side if left is false https://github.com/apache/datafusion/blob/3421b52605b00cd2e5a6498ea210cce196a19496/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs#L848-L853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
