alamb commented on PR #10950:
URL: https://github.com/apache/datafusion/pull/10950#issuecomment-2207303315

   Thanks for checking this out @efredine  -- I merged up from main and updated 
this PR to get it moving. Once it passes CI I think it is good to go
   
   Thanks again @marvinlanhenke 
   
   Like @efredine  I verified the benchmark now works without error:
   ```shell
   cargo bench --bench parquet_statistic
      Compiling bigdecimal v0.4.1
      Compiling datafusion v39.0.0 
(/Users/andrewlamb/Software/datafusion2/datafusion/core)
       Finished `bench` profile [optimized] target(s) in 1m 34s
        Running benches/parquet_statistic.rs 
(target/release/deps/parquet_statistic-c6fce472dea5abe8)
   Gnuplot not found, using plotters backend
   Extract row group statistics for Int64/extract_statistics/Int64
                           time:   [594.98 ns 596.23 ns 597.66 ns]
   Found 10 outliers among 100 measurements (10.00%)
     4 (4.00%) high mild
     6 (6.00%) high severe
   
   Extract data page statistics for Int64/extract_statistics/Int64
                           time:   [6.5665 µs 6.5848 µs 6.6047 µs]
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) high mild
     1 (1.00%) high severe
   
   Extract row group statistics for UInt64/extract_statistics/UInt64
                           time:   [576.78 ns 578.78 ns 581.09 ns]
   Found 3 outliers among 100 measurements (3.00%)
     2 (2.00%) high mild
     1 (1.00%) high severe
   
   Extract data page statistics for UInt64/extract_statistics/UInt64
                           time:   [6.8120 µs 6.8332 µs 6.8559 µs]
   Found 7 outliers among 100 measurements (7.00%)
     6 (6.00%) high mild
     1 (1.00%) high severe
   
   Extract row group statistics for F64/extract_statistics/F64
                           time:   [588.96 ns 592.68 ns 596.62 ns]
   
   Extract data page statistics for F64/extract_statistics/F64
                           time:   [7.5959 µs 7.6334 µs 7.6650 µs]
   
   Extract row group statistics for String/extract_statistics/String
                           time:   [897.07 ns 901.70 ns 907.19 ns]
   Found 5 outliers among 100 measurements (5.00%)
     3 (3.00%) high mild
     2 (2.00%) high severe
   
   Extract data page statistics for String/extract_statistics/String
                           time:   [25.507 µs 25.555 µs 25.609 µs]
   Found 2 outliers among 100 measurements (2.00%)
     1 (1.00%) high mild
     1 (1.00%) high severe
   
   Benchmarking Extract row group statistics for Dictionary(Int32, 
String)/extract_statistics/Dictionary(Int32, Stri...: Collecting 100 samples in 
estimated 5.00
   Extract row group statistics for Dictionary(Int32, 
String)/extract_statistics/Dictionary(Int32, Stri...
                           time:   [947.78 ns 954.30 ns 960.82 ns]
   Found 8 outliers among 100 measurements (8.00%)
     1 (1.00%) low severe
     7 (7.00%) low mild
   
   Benchmarking Extract data page statistics for Dictionary(Int32, 
String)/extract_statistics/Dictionary(Int32, Stri...: Collecting 100 samples in 
estimated 5.04
   Extract data page statistics for Dictionary(Int32, 
String)/extract_statistics/Dictionary(Int32, Stri...
                           time:   [25.602 µs 25.812 µs 26.109 µs]
   Found 8 outliers among 100 measurements (8.00%)
     7 (7.00%) high mild
     1 (1.00%) high severe
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to