jcsherin commented on PR #11287: URL: https://github.com/apache/datafusion/pull/11287#issuecomment-2211730373
Summary: - Marked as TODO: make the nullability of list field element configurable. This can be completed in a follow up PR after #11063. - Extract `merge_ordered_arrays` to `physical-expr-common`. It is required by both `nth_value` and `array_agg_ordered`. This can be moved back into `functions-aggregate` after the remaining functions are converted. - Simplify argument by using `nth_value_udaf` in `roundtrip_physical_plan`. @jayzhan211 Thank you for the code review and providing context. It was very helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
