andygrove commented on code in PR #638:
URL: https://github.com/apache/datafusion-comet/pull/638#discussion_r1670588372
##########
native/spark-expr/src/abs.rs:
##########
@@ -68,17 +71,15 @@ impl ScalarUDFImpl for CometAbsFunc {
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue,
DataFusionError> {
match self.inner_abs_func.invoke(args) {
- Err(DataFusionError::ArrowError(ArrowError::ComputeError(msg),
trace))
+ Err(DataFusionError::ArrowError(ArrowError::ComputeError(msg),
_trace))
Review Comment:
Yes, if we get an overflow error then we don't care about the trace. I have
renamed it to `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
