alamb commented on code in PR #11345:
URL: https://github.com/apache/datafusion/pull/11345#discussion_r1672097639
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -1015,15 +1050,21 @@ async fn concatenate_parallel_row_groups(
while let Some(task) = serialize_rx.recv().await {
let result = task.join_unwind().await;
let mut rg_out = parquet_writer.next_row_group()?;
- let (serialized_columns, _cnt) = result?;
+ let (serialized_columns, mut rg_reservation, _cnt) = result?;
for chunk in serialized_columns {
chunk.append_to_row_group(&mut rg_out)?;
+ rg_reservation.free();
+
let mut buff_to_flush = merged_buff.buffer.try_lock().unwrap();
+ file_reservation.try_resize(buff_to_flush.len())?;
Review Comment:
👍
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -1015,15 +1050,21 @@ async fn concatenate_parallel_row_groups(
while let Some(task) = serialize_rx.recv().await {
let result = task.join_unwind().await;
let mut rg_out = parquet_writer.next_row_group()?;
- let (serialized_columns, _cnt) = result?;
+ let (serialized_columns, mut rg_reservation, _cnt) = result?;
for chunk in serialized_columns {
chunk.append_to_row_group(&mut rg_out)?;
+ rg_reservation.free();
+
let mut buff_to_flush = merged_buff.buffer.try_lock().unwrap();
+ file_reservation.try_resize(buff_to_flush.len())?;
+
if buff_to_flush.len() > BUFFER_FLUSH_BYTES {
object_store_writer
.write_all(buff_to_flush.as_slice())
.await?;
+ rg_reservation.shrink(buff_to_flush.len());
Review Comment:
Since `file_reservation` seems to now be tracking `buff_to_flush`, not
`rg_reservation` I don't think `rg_reservation` needs to be changed on flush.
Also, `rg_reservation.free()` is called a few lines above, it should already
be zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
