lyne7-sc commented on code in PR #20049:
URL: https://github.com/apache/datafusion/pull/20049#discussion_r2746412855
##########
datafusion/functions-nested/src/repeat.rs:
##########
@@ -243,56 +240,75 @@ fn general_list_repeat<O: OffsetSizeTrait>(
list_array: &GenericListArray<O>,
count_array: &UInt64Array,
) -> Result<ArrayRef> {
- let data_type = list_array.data_type();
- let value_type = list_array.value_type();
- let mut new_values = vec![];
+ let counts = count_array.values();
Review Comment:
I agree. I’ve opened a follow-up issue to track this
https://github.com/apache/datafusion/issues/20075.
Since this could potentially introduce a user-facing behavioral change
around null semantics, I’d prefer to keep this PR focused on the performance
improvement. I can address the null-handling semantics separately in a
follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
