iffyio commented on code in PR #2185:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2185#discussion_r2759042694
##########
src/parser/mod.rs:
##########
@@ -14184,27 +14188,27 @@ impl<'a> Parser<'a> {
}
/// Parse a `CONNECT BY` clause (Oracle-style hierarchical query support).
- pub fn parse_connect_by(&mut self) -> Result<ConnectBy, ParserError> {
- let (condition, relationships) = if
self.parse_keywords(&[Keyword::CONNECT, Keyword::BY]) {
- let relationships = self.with_state(ParserState::ConnectBy,
|parser| {
- parser.parse_comma_separated(Parser::parse_expr)
- })?;
- self.expect_keywords(&[Keyword::START, Keyword::WITH])?;
- let condition = self.parse_expr()?;
- (condition, relationships)
- } else {
- self.expect_keywords(&[Keyword::START, Keyword::WITH])?;
- let condition = self.parse_expr()?;
- self.expect_keywords(&[Keyword::CONNECT, Keyword::BY])?;
- let relationships = self.with_state(ParserState::ConnectBy,
|parser| {
- parser.parse_comma_separated(Parser::parse_expr)
- })?;
- (condition, relationships)
- };
- Ok(ConnectBy {
- condition,
- relationships,
- })
+ pub fn maybe_parse_connect_by(&mut self) -> Result<Vec<ConnectByKind>,
ParserError> {
+ let mut clauses = Vec::with_capacity(2);
+ loop {
+ if let Some(idx) = self.parse_keywords_(&[Keyword::START,
Keyword::WITH]) {
Review Comment:
can we instead save `let idx = self.index` in the loop before calling the
parse method? looks like that would let us avoid introducing the
`parse_keywords_` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
