vaibhawvipul commented on code in PR #627: URL: https://github.com/apache/datafusion-comet/pull/627#discussion_r1676060588
########## native/core/src/execution/datafusion/expressions/cast.rs: ########## @@ -1709,6 +1722,37 @@ mod tests { assert_eq!(result.len(), 2); } + #[test] + fn test_cast_dict_string_to_dict_timestamp() -> DataFusionResult<()> { Review Comment: Hey this is named incorrectly. I have changed it. This test actually tests 'dict to timstamp array' cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org