andygrove commented on code in PR #3393:
URL: https://github.com/apache/datafusion-comet/pull/3393#discussion_r2771342571


##########
.github/workflows/spark_sql_test.yml:
##########
@@ -153,7 +153,7 @@ jobs:
         run: |
           cd apache-spark
           rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet 
cache requires cleanups
-          ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ${{ 
matrix.config.scan-env }} ENABLE_COMET_LOG_FALLBACK_REASONS=${{ 
github.event.inputs.collect-fallback-logs || 'false' }} \
+          NOLINT_ON_COMPILE=true ENABLE_COMET=true ENABLE_COMET_ONHEAP=true 
COMET_PARQUET_SCAN_IMPL=${{ matrix.config.scan-impl }} 
ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs 
|| 'false' }} \

Review Comment:
   We clone Spark and apply our patch. I don't think we care if it is well 
formatted just to be able to run the tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to