coderfender commented on code in PR #3351:
URL: https://github.com/apache/datafusion-comet/pull/3351#discussion_r2779942068
##########
dev/diffs/3.4.3.diff:
##########
@@ -1872,6 +1883,62 @@ index 593bd7bb4ba..32af28b0238 100644
}
assert(shuffles2.size == 4)
val smj2 = findTopLevelSortMergeJoin(adaptive2)
+diff --git
a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
+index f77b6336b81..b703603d26b 100644
+---
a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
++++
b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala
+@@ -18,7 +18,7 @@
+ package org.apache.spark.sql.execution.command
+
+ import org.apache.spark.SparkConf
+-import org.apache.spark.sql.{AnalysisException, QueryTest, Row}
++import org.apache.spark.sql.{AnalysisException, IgnoreComet, QueryTest, Row}
+ import org.apache.spark.sql.catalyst.util.CharVarcharUtils
+ import org.apache.spark.sql.connector.catalog.InMemoryPartitionTableCatalog
+ import org.apache.spark.sql.internal.SQLConf
+@@ -112,7 +112,8 @@ trait CharVarcharDDLTestBase extends QueryTest with
SQLTestUtils {
+ }
+ }
+
+- test("SPARK-33901: ctas should should not change table's schema") {
++ test("SPARK-33901: ctas should should not change table's schema",
++ IgnoreComet("comet native writer does not support empty dir / table
creation yet")) {
Review Comment:
Thank you . I did annotations and pushed a commit . However, per @comphead
's review, I made this PR just to copy the failing tests into the
`CometParquetWriterSuite` and created github issues for each of the failing
tests in spark 3x , spark 4x.
The plan is to create a CI pipeline (which doesn't interfere with main comet
workflows but runs a separate test suite with comet writer enabled and a
listener attached to make sure we are running the tests through native writer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
