JoshElkind commented on code in PR #20250:
URL: https://github.com/apache/datafusion/pull/20250#discussion_r2806245738
##########
datafusion/substrait/src/lib.rs:
##########
@@ -20,10 +20,6 @@
html_favicon_url =
"https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg";
)]
#![cfg_attr(docsrs, feature(doc_cfg))]
-// Make sure fast / cheap clones on Arc are explicit:
-// https://github.com/apache/datafusion/issues/11143
-#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
-#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
Review Comment:
wasn’t intentional, the crate-level deny(clippy::clone_on_ref_ptr) was
removed because the lint is now enabled for the whole workspace, but the test
allow for needless_pass_by_value is still useful so test code can pass owned
values without extra clones.
i’ve restored it as:
-> #![cfg_attr(test, allow(clippy::needless_pass_by_value))]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg"](https://raw.githubusercontent.com/apache/datafusion/19fe44cf2f30cbdd63d4a4f52c74055163c6cc38/docs/logos/standalone_logo/logo_original.svg"){kind=link}