hareshkh commented on PR #20382: URL: https://github.com/apache/datafusion/pull/20382#issuecomment-3916558148
@mbutrovich @comphead : Sorry, my bad here. This PR only fixes a bug introduced by https://github.com/apache/datafusion/pull/19759 so branch-51 and branch-52 (which use usize instead of AtomicUsize) do not have the bug. In **branch-52**, `try_shrink`: ```rust pub fn try_shrink(&mut self, capacity: usize) -> Result<usize> { if let Some(new_size) = self.size.checked_sub(capacity) { self.registration.pool.shrink(self, capacity); self.size = new_size; Ok(new_size) } else { internal_err!( "Cannot free the capacity {capacity} out of allocated size {}", self.size ) } } ``` Which already calls pool.shrink() correctly. I was debugging another issue I am running into and I thought this would be the fix for branch-51/branch-52 as well but that is not the case :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
