darmie commented on issue #20324: URL: https://github.com/apache/datafusion/issues/20324#issuecomment-3917493563
@adriangb you raise a valid point. My approach is a bit too broad. With a multi-conjunct predicate like `WHERE id = 123 AND long_message LIKE '%foo%'`, the RowFilter evaluates conjuncts incrementally (cheapest first via reorder_filters), so `long_message` probably only gets decoded for the ~1% of rows matching `id = 123`. I suppose that tightening the condition to only skip RowFilter when `predicate_cols == projection_cols` (exact match), and the predicate is a single conjunct. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
