gabotechs commented on issue #20396: URL: https://github.com/apache/datafusion/issues/20396#issuecomment-3919020503
> A possible alternative would be to keep annotations in a separate context structure keyed by plan nodes 🤔 Thinking about this, I'm not sure how I would do it properly, I see several problems with maintaining a separate context - The only key I can imagine for identifying a plan is it's Arc pointer address, and this is brittle as those can change at any time. - The `PhysicalOptimizerRule` API just returns an `Arc<dyn ExecutionPlan>`, and accepts just an `Arc<dyn ExecutionPlan>`, there's no further slot for us to return or accept anything else. My impression is that these two issues are enough to discard the option of a separate keyed struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
