andygrove commented on code in PR #3536:
URL: https://github.com/apache/datafusion-comet/pull/3536#discussion_r2822885361
##########
native/core/src/execution/operators/iceberg_scan.rs:
##########
@@ -221,15 +218,12 @@ impl IcebergScanMetrics {
/// Wrapper around iceberg-rust's stream that performs schema adaptation.
/// Handles batches from multiple files that may have different Arrow schemas
-/// (metadata, field IDs, etc.). Caches schema adapters by source schema to
avoid
-/// recreating them for every batch from the same file.
+/// (metadata, field IDs, etc.).
struct IcebergStreamWrapper<S> {
inner: S,
schema: SchemaRef,
- /// Cached schema adapter with its source schema. Created when schema
changes.
- cached_adapter: Option<(SchemaRef, Arc<dyn SchemaMapper>)>,
Review Comment:
Is caching no longer possible with DF52?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
