alamb commented on code in PR #20177:
URL: https://github.com/apache/datafusion/pull/20177#discussion_r2840964897
##########
datafusion/sql/src/select.rs:
##########
@@ -361,6 +361,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
// Process distinct clause
let plan = match select.distinct {
None => Ok(plan),
+ Some(Distinct::All) => Ok(plan),
Review Comment:
This is a good idea. I added this in 013122634
I also double checked and this syntax is also checked in the extended
sqllogictests:
https://github.com/search?q=repo%3Aapache%2Fdatafusion-testing%20%22select%20all%20*%22&type=code
And I ran that locally as well and verified it passes
```shell
INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
