neilconway commented on PR #20352: URL: https://github.com/apache/datafusion/pull/20352#issuecomment-3948432744
I realized that there was another subtlety when it comes to sliced arrays: the previous coding copied the entire backing buffer. That yields correct behavior, but for a slice that is only a small fraction of a much larger backing buffer, that's pretty inefficient. Not sure how common that scenario is in practice, but with a little offset math we can ensure the output buffer is compact, so I made that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
