friendlymatthew commented on code in PR #20698:
URL: https://github.com/apache/datafusion/pull/20698#discussion_r2884580623
##########
datafusion/datasource-parquet/src/row_filter.rs:
##########
@@ -437,15 +412,12 @@ fn pushdown_columns(
fn leaf_indices_for_roots(
root_indices: &[usize],
schema_descr: &SchemaDescriptor,
- nested: NestedColumnSupport,
) -> Vec<usize> {
- // For primitive-only columns, root indices ARE the leaf indices
- if nested == NestedColumnSupport::PrimitiveOnly {
- return root_indices.to_vec();
- }
Review Comment:
Just because a filter only references primitive columns doesn't mean Arrow
indices equal Parquet leaf indices.
Struct columns elsewhere in the schema still shift the leaf numbering. The
enum encoded the wrong signal (and was only used here), so I removed it and
always do the proper mapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
