alamb commented on PR #20505: URL: https://github.com/apache/datafusion/pull/20505#issuecomment-4000023135
> You should check with the author of https://github.com/apache/datafusion/pull/18393 that introduced that code. 😆 Indeed it was added in https://github.com/apache/datafusion/commit/c0e8bb501a7b62bb40c87edf16d46ee53bdaff73 and as you say there is no test coverage / failure for it. > I think maybe I just added that under the premise that "what's the point of having a dictionary array for InList if we are building a HashMap in front of it anyway?" Yeah, I also asked Codex about the PR and it didn't seem to find any problems -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
