UBarney commented on issue #17899: URL: https://github.com/apache/datafusion/issues/17899#issuecomment-4002931579
> First_value already has a [GroupsAccumulator implementation](https://github.com/apache/datafusion/pull/15266) > > [datafusion/datafusion/functions-aggregate/src/first_last.rs](https://github.com/apache/datafusion/blob/d9d847e22b91f462c047fbcd9076a00613cceb12/datafusion/functions-aggregate/src/first_last.rs#L207) > > Line 207 in [d9d847e](/apache/datafusion/commit/d9d847e22b91f462c047fbcd9076a00613cceb12) > > fn create_groups_accumulator( > nth_value aggregate doesn't however. Actually, `first_value` only uses GroupsAccumulator for PrimitiveType at the moment. https://github.com/apache/datafusion/blob/d9d847e22b91f462c047fbcd9076a00613cceb12/datafusion/functions-aggregate/src/first_last.rs#L180-L205 Since the issue in #16620 involves string arguments, it still hits the non-optimized path. I'll work on adding GroupsAccumulator support for strings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
