alamb commented on code in PR #20802:
URL: https://github.com/apache/datafusion/pull/20802#discussion_r2906421410
##########
datafusion-cli/src/object_storage/instrumented.rs:
##########
@@ -963,19 +972,57 @@ mod tests {
instrumented.set_instrument_mode(InstrumentedObjectStoreMode::Trace);
assert!(instrumented.requests.lock().is_empty());
let mut stream = instrumented.list(Some(&path));
- // Consume at least one item from the stream to trigger duration
measurement
+ // Sleep between stream creation and first poll to verify the timer
+ // starts on first poll, not at stream creation.
Review Comment:
this tightens up the tests, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
