rluvaton commented on PR #20806: URL: https://github.com/apache/datafusion/pull/20806#issuecomment-4027398791
As much as I would like to review and approve, the code is very complex and I'm not THAT familiar with the join code. what I usually when creating such PRs to help reviewers even when I already have the full implementation: 1. start with PR that does the bare minimum without support for filters and anything that complicate the code and use that when it is possible so tests suites will cover that as well 2. add features/optimizations one by one while also removing from the old code this will make it much easier to review and understand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
